Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8470 - Fix Unit Tests MockKExceptions #8471

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Feb 17, 2020

Not sure if this will work but let's see ⭐️

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2a42c30). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8471   +/-   ##
=========================================
  Coverage          ?   18.59%           
  Complexity        ?      459           
=========================================
  Files             ?      318           
  Lines             ?    12600           
  Branches          ?     1661           
=========================================
  Hits              ?     2343           
  Misses            ?    10058           
  Partials          ?      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a42c30...6899cf3. Read the comment docs.

Copy link
Contributor

@severinrudie severinrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants