Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

🎲🎲 Closes #8654: Fix breakage from customTabId rename #8656

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger rocketsroger requested review from a team February 21, 2020 19:51
@rocketsroger
Copy link
Contributor Author

This should pass checks when the new snapshot have the change from the rename

Copy link
Contributor

@psymoon psymoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boek boek changed the title Closes #8654: Fix breakage from customTabId rename 🎲 Closes #8654: Fix breakage from customTabId rename Feb 21, 2020
@boek boek changed the title 🎲 Closes #8654: Fix breakage from customTabId rename 🎲🎲 Closes #8654: Fix breakage from customTabId rename Feb 21, 2020
@liuche
Copy link
Contributor

liuche commented Feb 21, 2020

Merging this so we can get new AC snapshot

@liuche liuche merged commit 60d3805 into mozilla-mobile:master Feb 21, 2020
@rocketsroger rocketsroger deleted the FB_8654 branch February 21, 2020 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants