Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8594: Show correct info in ETP settings info #8687

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Feb 24, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #8687 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8687      +/-   ##
============================================
- Coverage     18.62%   18.61%   -0.02%     
  Complexity      464      464              
============================================
  Files           319      319              
  Lines         12737    12739       +2     
  Branches       1682     1682              
============================================
- Hits           2372     2371       -1     
- Misses        10163    10166       +3     
  Partials        202      202
Impacted Files Coverage Δ Complexity Δ
...ngprotection/TrackingProtectionBlockingFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...zilla/fenix/settings/TrackingProtectionFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...mponents/searchengine/FenixSearchEngineProvider.kt 55.43% <0%> (-1.09%) 10% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd3d29...13d3635. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants