This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
sync-integration-tests-fix-paths #8931
Merged
AaronMT
merged 3 commits into
mozilla-mobile:master
from
isabelrios:sync-integration-tests-fix-paths
Mar 4, 2020
Merged
sync-integration-tests-fix-paths #8931
AaronMT
merged 3 commits into
mozilla-mobile:master
from
isabelrios:sync-integration-tests-fix-paths
Mar 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8931 +/- ##
============================================
- Coverage 19% 18.97% -0.04%
Complexity 500 500
============================================
Files 327 327
Lines 12991 12991
Branches 1720 1720
============================================
- Hits 2469 2465 -4
- Misses 10313 10318 +5
+ Partials 209 208 -1
Continue to review full report at Codecov.
|
isabelrios
force-pushed
the
sync-integration-tests-fix-paths
branch
from
March 3, 2020 16:02
4b2e2c8
to
f8fd492
Compare
AaronMT
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, couple minor things
app/src/androidTest/java/org/mozilla/fenix/syncintegration/test_integration.py
Outdated
Show resolved
Hide resolved
AaronMT
approved these changes
Mar 3, 2020
app/src/androidTest/java/org/mozilla/fenix/syncintegration/test_integration.py
Outdated
Show resolved
Hide resolved
AaronMT
approved these changes
Mar 4, 2020
gmierz
pushed a commit
to gmierz/fenix
that referenced
this pull request
Mar 5, 2020
* sync-integration-tests-fix-paths * fix Jenkins file to store the report * address reviewer comments
severinrudie
pushed a commit
to severinrudie/fenix
that referenced
this pull request
Mar 18, 2020
* sync-integration-tests-fix-paths * fix Jenkins file to store the report * address reviewer comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some paths so that these tests can run anywhere without having to modify them.
Pull Request checklist
After merge
To download an APK when reviewing a PR: