Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

sync-integration-tests-fix-paths #8931

Merged

Conversation

isabelrios
Copy link
Contributor

This PR fixes some paths so that these tests can run anywhere without having to modify them.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #8931 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8931      +/-   ##
============================================
- Coverage        19%   18.97%   -0.04%     
  Complexity      500      500              
============================================
  Files           327      327              
  Lines         12991    12991              
  Branches       1720     1720              
============================================
- Hits           2469     2465       -4     
- Misses        10313    10318       +5     
+ Partials        209      208       -1
Impacted Files Coverage Δ Complexity Δ
...nix/components/toolbar/BrowserToolbarController.kt 62.2% <0%> (-2.33%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e2dd9...e688275. Read the comment docs.

@isabelrios isabelrios force-pushed the sync-integration-tests-fix-paths branch from 4b2e2c8 to f8fd492 Compare March 3, 2020 16:02
@isabelrios isabelrios requested a review from AaronMT March 3, 2020 16:40
Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple minor things

@isabelrios isabelrios marked this pull request as ready for review March 4, 2020 11:31
@AaronMT AaronMT merged commit a4d9300 into mozilla-mobile:master Mar 4, 2020
gmierz pushed a commit to gmierz/fenix that referenced this pull request Mar 5, 2020
* sync-integration-tests-fix-paths

* fix Jenkins file to store the report

* address reviewer comments
@liuche liuche mentioned this pull request Mar 12, 2020
32 tasks
severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020
* sync-integration-tests-fix-paths

* fix Jenkins file to store the report

* address reviewer comments
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants