This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #7158: Improves browser to search animation #8961
Merged
sblatz
merged 1 commit into
mozilla-mobile:master
from
sblatz:browser-to-search-animation-merge
Mar 5, 2020
Merged
For #7158: Improves browser to search animation #8961
sblatz
merged 1 commit into
mozilla-mobile:master
from
sblatz:browser-to-search-animation-merge
Mar 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekager
reviewed
Mar 4, 2020
@@ -293,6 +300,8 @@ class SearchFragment : Fragment(), UserInteractionHandler { | |||
} | |||
else -> awesomeBarView.isKeyboardDismissedProgrammatically | |||
} | |||
|
|||
// Note: Actual navigation happens in `handleEditingCancelled` in SearchController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - i like the comment but it looks a little weird at the bottom of this fun? Maybe at the top makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 😄
sblatz
force-pushed
the
browser-to-search-animation-merge
branch
2 times, most recently
from
March 4, 2020 17:43
57ab03d
to
5c4b483
Compare
sblatz
force-pushed
the
browser-to-search-animation-merge
branch
2 times, most recently
from
March 5, 2020 19:53
6a52ad9
to
621ae36
Compare
sblatz
force-pushed
the
browser-to-search-animation-merge
branch
from
March 5, 2020 19:55
621ae36
to
b35e94c
Compare
boek
approved these changes
Mar 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #8961 +/- ##
============================================
- Coverage 18.92% 18.89% -0.04%
Complexity 502 502
============================================
Files 330 330
Lines 13043 13059 +16
Branches 1725 1727 +2
============================================
- Hits 2468 2467 -1
- Misses 10364 10382 +18
+ Partials 211 210 -1
Continue to review full report at Codecov.
|
gmierz
pushed a commit
to gmierz/fenix
that referenced
this pull request
Mar 5, 2020
severinrudie
pushed a commit
to severinrudie/fenix
that referenced
this pull request
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: