Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #7158: Improves browser to search animation #8961

Merged

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Mar 4, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from boek March 4, 2020 00:59
@@ -293,6 +300,8 @@ class SearchFragment : Fragment(), UserInteractionHandler {
}
else -> awesomeBarView.isKeyboardDismissedProgrammatically
}

// Note: Actual navigation happens in `handleEditingCancelled` in SearchController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - i like the comment but it looks a little weird at the bottom of this fun? Maybe at the top makes sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 😄

@sblatz sblatz force-pushed the browser-to-search-animation-merge branch 2 times, most recently from 57ab03d to 5c4b483 Compare March 4, 2020 17:43
@sblatz sblatz requested a review from ekager March 4, 2020 17:48
@sblatz sblatz force-pushed the browser-to-search-animation-merge branch 2 times, most recently from 6a52ad9 to 621ae36 Compare March 5, 2020 19:53
@sblatz sblatz force-pushed the browser-to-search-animation-merge branch from 621ae36 to b35e94c Compare March 5, 2020 19:55
@codecov-io
Copy link

Codecov Report

Merging #8961 into master will decrease coverage by 0.03%.
The diff coverage is 17.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8961      +/-   ##
============================================
- Coverage     18.92%   18.89%   -0.04%     
  Complexity      502      502              
============================================
  Files           330      330              
  Lines         13043    13059      +16     
  Branches       1725     1727       +2     
============================================
- Hits           2468     2467       -1     
- Misses        10364    10382      +18     
+ Partials        211      210       -1
Impacted Files Coverage Δ Complexity Δ
...nix/components/toolbar/BrowserToolbarController.kt 62.2% <ø> (-2.33%) 0 <0> (ø)
.../java/org/mozilla/fenix/browser/BrowserAnimator.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/org/mozilla/fenix/search/SearchController.kt 72.85% <100%> (+1.21%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a260e...b35e94c. Read the comment docs.

@sblatz sblatz merged commit 3548e58 into mozilla-mobile:master Mar 5, 2020
@liuche liuche mentioned this pull request Mar 12, 2020
32 tasks
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants