Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #9076 - Upddate pipenv to run without error. #9077

Merged

Conversation

isabelrios
Copy link
Contributor

PR to fix an issue with pipenv which we use to launch our sync integration tests
Using this PR to fix also the path to the html report generated

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@isabelrios isabelrios self-assigned this Mar 10, 2020
@isabelrios isabelrios requested a review from AaronMT March 10, 2020 12:36
@isabelrios
Copy link
Contributor Author

PR changed since first commit, pipenv fixed the issue, so after running pipenv update, we need to update the Pipfile.lock.

Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally familiar with the style here but it looks fine to me.

@isabelrios isabelrios force-pushed the 9076-sync-int-tests-fix-jenkins branch from 3bdca8a to 1bdfe4d Compare March 12, 2020 08:46
@codecov-io
Copy link

Codecov Report

Merging #9077 into master will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9077      +/-   ##
============================================
- Coverage     19.54%   18.81%   -0.73%     
+ Complexity      511      502       -9     
============================================
  Files           329      331       +2     
  Lines         13130    13109      -21     
  Branches       1737     1731       -6     
============================================
- Hits           2566     2467      -99     
- Misses        10340    10432      +92     
+ Partials        224      210      -14
Impacted Files Coverage Δ Complexity Δ
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt 0% <0%> (-45.24%) 0% <0%> (-11%)
.../main/java/org/mozilla/fenix/theme/ThemeManager.kt 0% <0%> (-10.82%) 0% <0%> (ø)
...c/main/java/org/mozilla/fenix/components/Search.kt 91.66% <0%> (-8.34%) 2% <0%> (ø)
...rg/mozilla/fenix/components/toolbar/ToolbarMenu.kt 95.65% <0%> (-4.35%) 0% <0%> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 78.11% <0%> (-0.72%) 30% <0%> (ø)
...zilla/fenix/home/intent/DeepLinkIntentProcessor.kt 80.76% <0%> (-0.72%) 16% <0%> (-1%)
...rc/main/java/org/mozilla/fenix/GlobalDirections.kt 100% <0%> (ø) 2% <0%> (ø) ⬇️
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...illa/fenix/components/toolbar/BrowserInteractor.kt 100% <0%> (ø) 6% <0%> (-1%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c862ca9...1bdfe4d. Read the comment docs.

@isabelrios isabelrios changed the title For #9076 - Upddate pipenv to run without error For #9076 - Upddate pipenv to run without error. Mar 12, 2020
@AaronMT AaronMT merged commit 97b5754 into mozilla-mobile:master Mar 12, 2020
severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020
…la-mobile#9077)

* For mozilla-mobile#9076 - Upddate pipenv to run without error

* pipenv fixed the issue after update
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants