Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-6665 [v116] Handle Show ETP VC from coordinator #15256

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Add FXIOS-6665 [v116] Handle Show ETP VC from coordinator #15256

merged 1 commit into from
Jun 29, 2023

Conversation

aalaaeid
Copy link
Contributor

@aalaaeid aalaaeid commented Jun 29, 2023 •
edited by lmarceau
Loading

Jira ticket
Github issue

Description

  1. handling present the ETPMenuVC in a start method.
  2. Added unit test for the ETPMenuVC showing.

Pull requests checks where applicable

  • Fill in the three TODOs above (tickets number and description of your work)
  • The PR name follows our naming guidelines
  • Accessibility implemented and tested (minimum Dynamic Text and VoiceOver)
  • Unit tests written and passing
  • Documentation / comments for complex code and public methods

@aalaaeid aalaaeid requested a review from a team as a code owner June 29, 2023 13:44
@aalaaeid aalaaeid requested a review from OrlaM June 29, 2023 13:44
@lmarceau lmarceau self-requested a review June 29, 2023 14:23
@lmarceau lmarceau changed the title Add FXIOS-14893 [v116] Handle Show ETP VC from coordinator Add FXIOS-6665 [v116] Handle Show ETP VC from coordinator Jun 29, 2023
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 35.51%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 34.21

File Coverage
EnhancedTrackingProtectionCoordinator.swift 89.29% ✅

Generated by 🚫 Danger Swift against db64262

@lmarceau lmarceau merged commit 89605b6 into mozilla-mobile:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarceau lmarceau lmarceau approved these changes

@OrlaM OrlaM Awaiting requested review from OrlaM OrlaM is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalaaeid @mobiletest-ci-bot @lmarceau