Refactor FXIOS-7856 [Multi-window] Fix telemetry tabManager reference #19966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 30.94
Generated by 🚫 Danger Swift against c67202a |
…etric for multi-window
mattreaganmozilla
force-pushed
the
mr/7856
branch
from
2c862ce
to
c67202a
Compare
OrlaM
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Partial work towards:
Jira ticket
Github issue
💡 Description
This removes the single tab manager reference from the TelemetryWrapper and updates the tab count metric to work for multi-window.
This also fixes an issue where the
defaultTabManagerwould be incorrectly retained and prevent it from being freed when its associated iPad window is closed.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)