-
Notifications
You must be signed in to change notification settings - Fork 262
[meta][ux] Tracking Protection #343
Comments
There are no strings in these design to approve. @antlam is going to provide the badged shield icon and the disabled icon (note: they make look different than my hack job! 😀 ) |
Here is the spec page for the drawer. Visual spec coming later. Strings are TBD. @mheubusch @BrianNJones |
The icon with the counter is giving me issues. Will post later. Here are the others though, in SVG :) |
Got it! trackingprotection-medium-counter.zip Here's the approved icon with the space cut-out for the counter. Note: SF Pro Text, Medium, 8px |
@lime124 How do you want the drawer to look on smaller screen sizes? Right now the 4S - SE that would take up the entire screen. Is that OK? |
Looks like the spec pages cover all the linked issues. All strings have been approved by @BrianNJones . Filing a follow up issue for one string Brian would like to tweak. |
@boek and I just discussed the drawer width question and figured it out. tl;dr is we are going to specify a max width for the drawer so it doesn't take up the whole screen on say an ipad in landscape, as well as have a min for the gap so that it can be an acceptable tap area to close the drawer. |
@antlam if I could get the assets here <3 |
@boek try these! |
Handling the strings-approved labels - not doing anything for this meta bc it doesn't look like it has any strings. |
Hey @lime124, we wanted to get your input on the A couple of ideas we tossed around were replacing the text with an infinity symbol or some sort of other glyph. Or potentially just showing the absolute number until we can patch it in the next release. |
It should be 99+ (see Note B in that first mock I posted). This was reviewed by Michelle (prior to @BrianNJones joining us) and should be localization friendly. |
For my own sanity, testing out the idea of creating a meta issue to track the various issues to consider while designing.
The text was updated successfully, but these errors were encountered: