Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

[meta][ux] Tracking Protection #343

Closed
5 tasks done
lime124 opened this issue Aug 23, 2017 · 13 comments
Closed
5 tasks done

[meta][ux] Tracking Protection #343

lime124 opened this issue Aug 23, 2017 · 13 comments
Assignees

Comments

@lime124
Copy link
Collaborator

lime124 commented Aug 23, 2017

For my own sanity, testing out the idea of creating a meta issue to track the various issues to consider while designing.

@lime124 lime124 added the UX label Aug 23, 2017
@lime124 lime124 self-assigned this Aug 23, 2017
@lime124
Copy link
Collaborator Author

lime124 commented Sep 11, 2017

ixd flow - url bar trackers

visual design - url bar trackers

There are no strings in these design to approve. @antlam is going to provide the badged shield icon and the disabled icon (note: they make look different than my hack job! 😀 )

@lime124
Copy link
Collaborator Author

lime124 commented Sep 11, 2017

Here is the spec page for the drawer. Visual spec coming later. Strings are TBD. @mheubusch @BrianNJones

/cc @bbinto, @antlam

ixd flow - drawer

@antlam
Copy link

antlam commented Sep 11, 2017

The icon with the counter is giving me issues. Will post later. Here are the others though, in SVG :)

trackingprotectiong-medium-small.zip

@antlam
Copy link

antlam commented Sep 12, 2017

Got it! trackingprotection-medium-counter.zip

Here's the approved icon with the space cut-out for the counter.

Note: SF Pro Text, Medium, 8px

@Sdaswani Sdaswani added this to the Ebony* milestone Sep 12, 2017
@lime124
Copy link
Collaborator Author

lime124 commented Sep 13, 2017

Here is the visual design spec!

visual design - drawer

LMK if there are any questions!

@boek
Copy link
Contributor

boek commented Sep 13, 2017

@lime124 How do you want the drawer to look on smaller screen sizes? Right now the 4S - SE that would take up the entire screen. Is that OK?

@lime124
Copy link
Collaborator Author

lime124 commented Sep 13, 2017

Looks like the spec pages cover all the linked issues. All strings have been approved by @BrianNJones . Filing a follow up issue for one string Brian would like to tweak.

@lime124
Copy link
Collaborator Author

lime124 commented Sep 14, 2017

@boek and I just discussed the drawer width question and figured it out.

tl;dr is we are going to specify a max width for the drawer so it doesn't take up the whole screen on say an ipad in landscape, as well as have a min for the gap so that it can be an acceptable tap area to close the drawer.

@boek
Copy link
Contributor

boek commented Sep 15, 2017

@antlam if I could get the assets here <3

@antlam
Copy link

antlam commented Sep 19, 2017

trackingprotection-PDF.zip

@boek try these!

@Sdaswani Sdaswani modified the milestones: Ebony*, Folly Sep 19, 2017
@liuche
Copy link
Contributor

liuche commented Sep 28, 2017

Handling the strings-approved labels - not doing anything for this meta bc it doesn't look like it has any strings.

@boek
Copy link
Contributor

boek commented Nov 1, 2017

Hey @lime124, we wanted to get your input on the +99 having potential localization issues.

A couple of ideas we tossed around were replacing the text with an infinity symbol or some sort of other glyph. Or potentially just showing the absolute number until we can patch it in the next release.

@lime124
Copy link
Collaborator Author

lime124 commented Nov 1, 2017

It should be 99+ (see Note B in that first mock I posted). This was reviewed by Michelle (prior to @BrianNJones joining us) and should be localization friendly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants