Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Find in Page is worthless #3699

Closed
WendellaBee opened this issue Feb 27, 2023 · 3 comments · Fixed by #3894
Closed

Find in Page is worthless #3699

WendellaBee opened this issue Feb 27, 2023 · 3 comments · Fixed by #3894
Labels
Bug 🐞

Comments

@WendellaBee
Copy link

WendellaBee commented Feb 27, 2023 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Launch page in Fire Fox Focus, I searched for rock and roll hall of fame and opened the wikipedia page for it.
  2. Open Find in page and search for 2017
  3. Using the Find in page navigation find the 2017 inductees

Expected behavior

You find the 2017 inductees

Actual behavior

There is no effing navigation for Find in page. Pay for some actual quality engineers!

Device & build information

  • Device : iPad Air 5th generation, 16.3.1
  • Build version: 110.0 (16656)
  • First seen version: It has been here for a few builds

Notes

Attachments:

┆Issue is synchronized with this Jira Task
@WendellaBee
Copy link
Author

https://share.icloud.com/photos/0fflN0fb6H8ve8N8ZIdrD9GEQ

@abodea
Copy link
Member

abodea commented Feb 27, 2023

Hello, thank you for adding this issue, I will move it to the Focus repo as this is not related to Firefox.

@abodea abodea transferred this issue from mozilla-mobile/firefox-ios Feb 27, 2023
@95atxf7h
Copy link

This is still an issue. There is no navigation on iPhone either when doing “find in page”.

sryze added a commit to sryze/focus-ios that referenced this issue Oct 25, 2023
@sryze
Fix invisible Find Previous & Find Next buttons
30a4610 
Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.

Fixes mozilla-mobile#3699
@sryze sryze mentioned this issue Oct 25, 2023
Merged
sryze added a commit to sryze/focus-ios that referenced this issue Feb 9, 2024
@sryze
Fix invisible Find Previous & Find Next buttons
ec5f63a 
Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.

Fixes mozilla-mobile#3699
isabelrios added a commit that referenced this issue Mar 4, 2024
@sryze @isabelrios
Fix missing buttons in Find In Page bar (#3894)
cb89e40 
* Fix invisible Find Previous & Find Next buttons

Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.

Fixes #3699

* Make Find Previous / Find Next buttons initially disabled

When the user hasn't entered any text, the previous/next buttons were
not made disabled, which could be a little bit misleading and was not
consistent with the case where there are no search results.

---------

Co-authored-by: isabelrios <isabelrios@gmail.com>
isabelrios added a commit to isabelrios/firefox-ios that referenced this issue Mar 4, 2024
@sryze @isabelrios
[focus-ios] Fix missing buttons in Find In Page bar (mozilla-mobile/f…
40ee51d 
…ocus-ios#3894)

* Fix invisible Find Previous & Find Next buttons

Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.

Fixes mozilla-mobile/focus-ios#3699

* Make Find Previous / Find Next buttons initially disabled

When the user hasn't entered any text, the previous/next buttons were
not made disabled, which could be a little bit misleading and was not
consistent with the case where there are no search results.

---------

Co-authored-by: isabelrios <isabelrios@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing buttons in Find In Page bar sryze/focus-ios
3 participants
@WendellaBee @abodea @95atxf7h