Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Match Focus Android 'Loading bar' UI #91

Closed
antlam opened this issue Jul 14, 2017 · 12 comments
Closed

Match Focus Android 'Loading bar' UI #91

antlam opened this issue Jul 14, 2017 · 12 comments
Assignees
Milestone

Comments

@antlam
Copy link

antlam commented Jul 14, 2017

Firefox Focus on Android is actually using a Photon-gradient loading bar that we plan on using across Mobile. I think this is strictly a UI matter but it would be more consistent if we could unify the two Focus apps here.

Focus on iOS is currently using an old loading bar UI.

@Sdaswani
Copy link
Contributor

@bkmunar my estimate is 1.5 days - agree?

@bkmunar
Copy link
Contributor

bkmunar commented Aug 21, 2017

Is there a mock for this? unsure on what to be building

@bbinto bbinto modified the milestones: Denim, Cobalt Aug 22, 2017
@lime124
Copy link
Collaborator

lime124 commented Aug 23, 2017

I'm going to need either @antlam or @brampitoyo to provide what you need. I'm not sure what the colors are. I believe this is what antlam is after:

mozilla-mobile/focus-android#1132

@brampitoyo
Copy link
Contributor

Here’s a visual design spec that tries to unify the iOS and Android progress bar as per @antlam’s original comment.

ios spec progress bar

@brampitoyo brampitoyo self-assigned this Aug 23, 2017
@antlam
Copy link
Author

antlam commented Aug 27, 2017

Thanks @brampitoyo ! note: this is iOS so it will likely be px instead of dp. But the numbers are still correct!

@bkmunar
Copy link
Contributor

bkmunar commented Aug 30, 2017

Better to overestimate: M

@antlam
Copy link
Author

antlam commented Aug 30, 2017

@bkmunar I really suggest playing with it on an Android device as well since this includes a lot of motion specific design elements.

@pocmo made the one on Android. Maybe he has pro-tips 😄

@pocmo
Copy link

pocmo commented Aug 30, 2017

@walkingice implemented it for Fennec and we just stole the code for Focus. 😂

@pocmo
Copy link

pocmo commented Aug 30, 2017

There's a GIF here:
https://github.com/walkingice/Progressbar/blob/master/misc/imgs/screenshot.gif

Note that there's an additional animation when loading has completed.

@bkmunar
Copy link
Contributor

bkmunar commented Aug 31, 2017

I saw his code for it! Now I just have to translate it into iOS :P Hopefully @walkingice can help me through that process

@bbinto bbinto added the ENG | L label Sep 5, 2017
@bbinto
Copy link

bbinto commented Sep 5, 2017

@bkmunar to give @antlam a build for review

@antlam
Copy link
Author

antlam commented Sep 5, 2017

Reviewed initial build, left feedback comments for @bkmunar via Slack.

  • pulsing animation
  • finishing animation
  • left aligned bar (doesn't show rounded left-end until finishing animation)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants