This repository has been archived by the owner on Apr 28, 2018. It is now read-only.
No issue: Add scripts/places_missing_data script. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a DB, this will find places with missing data. I intend to follow this up with additional commits that: 1. Provide a UI that will allow us to create our own crosswalk: it will pull place from the list of places missing data, prompt the user to enter in urls for TA, wikipedia, and the place's website, and store these on the server. 2. Uses these new IDs to fetch provider data into the DB: I expect this will either add to a pre-cached DB or interface directly with our places fetching. Suggestions welcome on approaches! Other considerations: * Should we build an interface to overwrite place data with custom data? (e.g. so antlam could set custom reviews or trivia facts). Firebase console doesn't work now that we have so much data. :( * How would these tools work if we wanted to customize the place list? (e.g. entirely hand-crafted or we remove undesired places) wrt ^, it could help me to get more context on how we currently fetch places.
|
Merging into my solution for #25. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue: Add scripts/places_missing_data.
Given a DB, this will find places with missing data.
I intend to follow this up with additional commits that:
place from the list of places missing data, prompt the user to enter in
urls for TA, wikipedia, and the place's website, and store these on the
server.
this will either add to a pre-cached DB or interface directly with our
places fetching. Suggestions welcome on approaches!
Other considerations:
so antlam could set custom reviews or trivia facts). Firebase console doesn't
work now that we have so much data. :(
entirely hand-crafted or we remove undesired places)
wrt ^, it could help me to get more context on how we currently fetch places.