-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local dockerfiles #2428
Fix local dockerfiles #2428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for me, on Ubuntu:
~/balrog2$ docker-compose up
ERROR: The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for services.balrogdb: 'platform'
@gbrownmozilla it might be the What is the output of |
I'll look into an upgrade tomorrow. |
It's probably a good idea to update to a newer $ docker-compose version
Docker Compose version v2.2.3 My |
I upgraded to docker-compose 2.2.3, and that works fine. I had to do that upgrade manually, and I noticed the site said 1.x is still considered the latest stable release, so others might trip over the same issue, but if we need it... |
@gbrownmozilla I see. We need it to run Balrog locally on M1/ARM chips. I could add a |
I agree we need to support arm. docker-compose-arm.yml is an interesting alternative. I don't have a strong feeling one way or the other: I trust your best judgment to either go ahead with this patch as-is, or use docker-compose-arm.yml. |
@gbrownmozilla it turns out I can override the keys in the |
I ran into a few issues running/building balrog locally. This PR contains my fixes.
appstream
repo when installing nmap-ncat in theDockerfile.nginx
image. This issue is related to CentOS 8 reaching End Of Life at the end of 2021. Theopenresty/openresty:centos
image we are using is based oncentos:8
python:python:3.8-slim
image we are basing theDockerfile.test
image on. This was causing an error when building thebrotli
wheel onpip install