Bug763005 ability to update rules #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very very happy to have the newlines cleaned up, no need to apologize for that! This looks fine to me, feel free to merge at any time. |
|
Landed afdbbbb |
JohanLorenzo
pushed a commit
to JohanLorenzo/balrog
that referenced
this pull request
Sep 9, 2016
lineman grunt spec-e2e. 👍?
JohanLorenzo
pushed a commit
to JohanLorenzo/balrog
that referenced
this pull request
Sep 9, 2016
…el-hiding bug 1139915: Check for null on backgroundRate and priority to avoid hiding labels when labels are (validly) 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bhearsum r?
First of all: I'm sorry for having an anal editor that cleans up all trailing spaces left in the files. It makes the diff slightly harder to look at. I could probably figure out how to solve that temporarily if it's too extreme for you.
Without this change it could never have been possible to update a rule. I just couldn't see it anywhere in the git history.
The real difference (the genius of this patch) is the conditional added to
rule_form_row.htmlbecause that template is used both for new rules and for editing forms.