Feat/deserialize and certificate parts #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed some deprecated impls and changed the "reason" string from the debug string to the human-readable message.
This helps when creating a localized APS manually.
This helps when manually building an APS instance.
* Fix stack-overflow in Error's Display impl Also removed some deprecated impls and changed the "reason" string from the debug string to the human-readable message. * Remove unused lifetime param * Use thiserror and improve the details in our error
…erialize-and-certificate-parts
@jrconlin which PRs are you referring to? |
|
The ones listed above from @AzureMarker. I'm rolling these from the separate branch into master so that we can provide the new owner of the official "a2" library a single PR that contains the new changes. |
…alize-and-certificate-parts
HarryET
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Mark's PRs.
Run through
clippy&fmt.Prepare for merge to a2's new owner https://github.com/WalletConnect/a2