Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: channel_ids should continue being represented in hyphenated format #561

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix: channel_ids should continue being represented in hyphenated format #561

merged 1 commit into from
Jan 19, 2024

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Jan 19, 2024

as they already are in the channel_id column and in chidmessageid

Closes: SYNC-4076

@pjenvey
fix: channel_ids should continue being represented in hyphenated format
096d79f 
as they already are in the channel_id column and in chidmessageid

Closes: SYNC-4076
@pjenvey pjenvey requested a review from jrconlin January 19, 2024 21:40
jrconlin
jrconlin approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those damn channelIDs are going to be the death of me.

@jrconlin
Copy link
Member

see also #562

@pjenvey
Copy link
Member Author

pjenvey commented Jan 19, 2024

#366 also related

@pjenvey pjenvey merged commit 661a705 into master Jan 19, 2024
1 check passed
@pjenvey pjenvey deleted the fix/chid-hyphenated-SYNC-4076 branch January 19, 2024 22:37
jrconlin pushed a commit that referenced this pull request Jan 29, 2024
@pjenvey @jrconlin
fix: channel_ids should continue being represented in hyphenated form…
c8ce0c6 
…at (#561)

as they already are in the channel_id column and in chidmessageid

Closes: SYNC-4076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjenvey @jrconlin