Update README.rst and axe_selenium_python/package-lock.json from axe-… #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core 3.1.1 to 3.1.2, using "integrity" value copied from https://github.com/pa11y/pa11y-runner-axe/blob/master/package-lock.json
1 similar comment
|
I'm not familiar with Coverall coverage reports. Are the 2 reports basically just saying that the amount of code covered by the tests is unchanged by this pull request? |
|
@RussellJQA yep |
|
Thank you @RussellJQA |
|
You're welcome @m8ttyB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.rst and axe_selenium_python/package-lock.json from axe-core 3.1.1 to 3.1.2, using "integrity" value copied from https://github.com/pa11y/pa11y-runner-axe/blob/master/package-lock.json
I copied https://cdnjs.cloudflare.com/ajax/libs/axe-core/3.1.2/axe.min.js to my local axe-selenium-python\axe_selenium_python\node_modules\axe-core\min.js.
And I tested with tox, but using just Python 3.7 (what I have installed) rather than both Python 2.7 and Python 3.6, by making a minor change to my local tox.ini file:
@@ -1,7 +1,7 @@
[tox]
-envlist = py27, py36, flake8
+envlist = py37, flake8
The axe tests passed, but there were some complaints from flake8:
c:\projects\python\selenium\axe-selenium-python.tox\flake8\lib\site-packages\pycodestyle.py:113: FutureWarning: Possible nested set at position 1
EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
.\setup.py:3:1: I001 isort found an import in the wrong position
.\setup.py:5:1: I003 isort expected 1 blank line in imports, found 0
...
Most of them seem similar to closed issue gforcada/flake8-isort#65, which I don't understand since I'm running the latest version of flake8.
But I don't think that's related to my changes.
I've attached a copy of the tox output.
tox.log