Support verifying legacy DSA signatures in Go 1.16 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.16 removed support for DSA signatures from crypto/x509. This change gives those applications that need to verify legacy PKCS7 certificates, a little more time to migrate off of DSA.
|
Thanks! Closing in favor of #55 for the reasons mentioned in my PR there. |
jcharum
pushed a commit
to grailbio/base
that referenced
this pull request
Jun 2, 2022
Summary: AWS Identity Documents are signed with DSA-with-SHA1 signatures, and DSA is removed from x509/crypto as of Go 1.16. This follows an approach done by hashicorp/vault#12340, by forking in https://github.com/mozilla-services/pkcs7 and applying the DSA fix mozilla-services/pkcs7#50. Test Plan: - Tested Bazel build and go build from within the folder Reviewers: aeiser, dborcherding, sdunn, anguyen, gvitta, bbentson Reviewed By: dborcherding, sdunn Subscribers: jcharumilind, dnicolaou, pboyapalli, smahadevan Differential Revision: https://phabricator.grailbio.com/D66326 fbshipit-source-id: cafa39b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.16 removed support for DSA signatures from crypto/x509. This change
gives those applications that need to verify legacy PKCS7 certificates,
a little more time to migrate off of DSA.
Fixes #47