Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Pages do not default to English #3231

Closed
ianb opened this issue Jul 27, 2017 · 3 comments
Closed

Pages do not default to English #3231

ianb opened this issue Jul 27, 2017 · 3 comments
Assignees

Comments

@ianb
Copy link
Contributor

ianb commented Jul 27, 2017

When fetching a page with requests I get a page in... maybe Arabic (ar)? Except there's also Acholi (ach, alphabetically before ar), seemingly in the same page. What craziness is this?!?

@jaredhirsch
Copy link
Member

Fixed upstream, waiting on npm publish to update the package

@jaredhirsch
Copy link
Member

@jaredhirsch jaredhirsch self-assigned this Aug 16, 2017
@jaredhirsch
Copy link
Member

jaredhirsch commented Aug 16, 2017

Unfortunately, fluent-langneg 0.0.3 doesn't fix the bug as I'd expected.

The default is returned if Accept-Language is empty, but in the case of Accept-Language: *, it now returns all the languages in alphabetical order. I guess that's probably the correct behavior, relative to the spec, but if googlebot is seeing arabic, maybe the accepts library is passing '*' when the header is missing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants