Fix #hello onboarding #4954

chenba · 2018-09-25T21:54:40Z

jaredhirsch

nice catch! typo in the test assert statement, otherwise good to land

jaredhirsch · 2018-09-25T23:43:02Z

test/test.js

+    await driver.get(`${backend}/#hello`);
+    await driver.setContext(firefox.Context.CONTENT);
+    const slideFrame = await driver.wait(until.elementLocated(By.id(SLIDE_IFRAME_ID)));
+    assert(slideFrame, "Navgating to #hello should show onboarding");


"Navigating"

Typo's been fixed. Thanks!

jaredhirsch previously requested changes Sep 25, 2018

View reviewed changes

Fix #hello onboarding. (mozilla-services#4886)

45f6def

chenba force-pushed the 4886-hello branch from 4ac477a to 45f6def Compare September 25, 2018 23:50

chenba merged commit d1015ea into mozilla-services:master Sep 26, 2018

chenba deleted the 4886-hello branch September 26, 2018 00:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #hello onboarding #4954

Fix #hello onboarding #4954

chenba commented Sep 25, 2018

jaredhirsch left a comment

jaredhirsch Sep 25, 2018

Fix #hello onboarding #4954

Fix #hello onboarding #4954

Conversation

chenba commented Sep 25, 2018

jaredhirsch left a comment

Choose a reason for hiding this comment

jaredhirsch Sep 25, 2018

Choose a reason for hiding this comment