Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a precondition header validator/extractor #60

Merged
merged 1 commit into from
Oct 12, 2018
Merged

feat: add a precondition header validator/extractor #60

merged 1 commit into from
Oct 12, 2018

Conversation

bbangert
Copy link
Member

Issue #48

@bbangert bbangert requested review from pjenvey and rfk October 12, 2018 17:05
pjenvey
pjenvey previously approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@pjenvey pjenvey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though now I'm wondering if extractors allow returning a Result<Option< of something?

@bbangert bbangert merged commit 15ae10a into master Oct 12, 2018
@bbangert bbangert deleted the feat/issue-48 branch October 12, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjenvey pjenvey pjenvey approved these changes

@rfk rfk Awaiting requested review from rfk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbangert @pjenvey