feat: fail the health check after SYNC_LBHEARTBEAT_TTL elapses #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethowitz
reviewed
Jun 22, 2022
| pub lbheartbeat_ttl: Option<u32>, | ||
| /// Percentage of `lbheartbeat_ttl` time to "jitter" (adds additional, | ||
| /// randomized time) | ||
| pub lbheartbeat_ttl_jitter: u32, |
There was a problem hiding this comment.
nit: should this be Option<u32> since lbheartbeat_ttl is an Option<u32>? Also, I don't feel strongly about this, but I'm wondering if it would be clearer to store the jitter as f32 directly since it's a percentage
There was a problem hiding this comment.
I somewhat followed contile's jitter setting here, it's also an integer and there's no need to support fractional percent values. It sets a default so no Option either -- I'm guessing SRE won't explicitly set a jitter (contile hasn't, still using the default) but they still have the option if necessary.
Whereas the heartbeat_ttl setting also toggles this on or off so deserves an Option.
ethowitz
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Closes #1330