Add support for new notification selectors #243
Merged
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4handjr
approved these changes
Feb 11, 2019
|
Looks like there are some flake8 issues. Could you take a look at the travis build? |
yes, sorry. I just reinstalled my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notifications have been refactored in FF (see: https://phabricator.services.mozilla.com/D17699) and there is no anonymous element anymore. Instead, we can use
find_elementdirectly and use aby.CLASS_NAMEselector.This PR updates the notification code to be compatible with Nightly 67.0a1 and above, while keeping backward compatibility for older versions.
This patch has been tested locally on https://github.com/mozilla/addons-frontend.