Add request FxA BrowserID auth backend and HTTPie related Auth plugin #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natim
force-pushed
the
add-httpie-browserid-auth
branch
from
c59e7d1
to
480aa2b
Compare
Natim
force-pushed
the
add-httpie-browserid-auth
branch
from
480aa2b
to
47142e5
Compare
|
r? @rfk |
Natim
force-pushed
the
add-httpie-browserid-auth
branch
from
25c0b27
to
4b23120
Compare
|
@Natim this is great, thank you! I've a couple of small nits. |
| Using Firefox Account BrowserID with Requests | ||
| ============================================= | ||
|
|
||
| You can use the ``FxABrowserIdAuth`` to build the BrowserId assertion: |
There was a problem hiding this comment.
Suggest capitalizing as "BrowserID" uniformly throughout, which is mostly how we've styled it in other places.
@rfk review.
Natim
force-pushed
the
add-httpie-browserid-auth
branch
from
a801b51
to
f005b00
Compare
|
I might have addressed all your comments :) |
Natim
force-pushed
the
add-httpie-browserid-auth
branch
from
f005b00
to
0ad5cbf
Compare
|
👍 |
Natim
added a commit
that referenced
this pull request
Jul 23, 2015
Add request FxA BrowserID auth backend and HTTPie related Auth plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.