Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a LICENSE to this repository. #2

Closed
floatingatoll opened this issue Jan 25, 2018 · 3 comments
Closed

Please add a LICENSE to this repository. #2

floatingatoll opened this issue Jan 25, 2018 · 3 comments

Comments

@floatingatoll
Copy link

Hi! This repository contains public unlicensed content, which means that it defaults to "All rights reserved", prohibiting non-Mozilla people from forking/patching/etc. Please consider adding a LICENSE - most likely our standard MPL2 would be appropriate - or, instead, marking this repository as private if it's not intended to be open content.

MPL2 plain-text: https://www.mozilla.org/media/MPL/2.0/index.815ca599c9df.txt

@erogol
Copy link
Contributor

erogol commented Feb 13, 2018

I add the license. Thx for pointing.

@erogol erogol closed this as completed Feb 14, 2018
@r9y9
Copy link

r9y9 commented Apr 4, 2018

Sorry to write on a closed issue but I would like to leave a comment on this. I'm looking your code and find there's a lot of similar code with https://github.com/r9y9/tacotron_pytorch, that I've originally written. Assuming you fork my work, should this be mentioned somewhere in README or code? It does not feel right you add a Mozilla license without acknowledgement. Technically speaking a copy of MIT license should be included but I'm ok with just a one-line credit; some of the work was initially taken from the repository ${link}.

@erogol
Copy link
Contributor

erogol commented Apr 4, 2018

@r9y9 added a fair share reference as needed. Thanks for the ping.

erogol pushed a commit that referenced this issue Apr 25, 2018
erogol pushed a commit that referenced this issue Apr 25, 2018
erogol pushed a commit that referenced this issue Apr 25, 2018
erogol pushed a commit that referenced this issue Apr 25, 2018
erogol pushed a commit that referenced this issue Apr 24, 2019
erogol pushed a commit that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants