Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

send load_trigger and visibility performance telemetry for about:newtab #2539

Closed
dmose opened this issue May 3, 2017 · 5 comments
Closed

send load_trigger and visibility performance telemetry for about:newtab #2539

dmose opened this issue May 3, 2017 · 5 comments
Assignees
@dmose
Labels
Has PR MVP P1 Performance
Milestone
Bridge on the Riv...

Comments

@dmose
Copy link
Member

dmose commented May 3, 2017

This will involve porting over AbsPerf.js and perhaps some of the contents of PerfMeter.js to a new ASPerf.jsm. We'll want to use the hidden DOM Window's performance.mark if we can make it work to get marks into the profiler.
@dmose dmose added this to the Yoho (May 14) milestone May 3, 2017
@dmose dmose self-assigned this May 3, 2017
@Mardak Mardak added Fx55 and removed Fx55 labels May 15, 2017
@dmose
Copy link
Member Author

dmose commented May 23, 2017

This is basically working; need to clean it up for review.

@dmose
Copy link
Member Author

dmose commented May 23, 2017 •
edited
Loading

Note that it depends on #2538 landing in m-c first.

@dmose dmose mentioned this issue May 23, 2017
Closed
@dmose dmose changed the title mark duration between BrowserOpenTab and visibility notification event send load_trigger and visibility performance telemetry for about:newtab Jun 5, 2017
@dmose
Copy link
Member Author

dmose commented Jun 5, 2017

This will want to include load_trigger_ts, load_trigger_type, new_tab_preloaded (maybe), and visibility_event_fired_ts.

#2653 and https://github.com/mozilla/activity-stream/pull/2660/files is where the schema details are being hammered out.

dmose added a commit to dmose/activity-stream that referenced this issue Jun 7, 2017
@dmose
feat(performance): mozilla#2539 Add perf telemetry + infrastructure
73055b8
@dmose
Copy link
Member Author

dmose commented Jun 7, 2017

#2681 is the work in progress PR. I think new_tab_preloaded will spin out to another issue in order to get this landed sooner.

@dmose dmose mentioned this issue Jun 7, 2017
Closed
dmose added a commit to dmose/activity-stream that referenced this issue Jun 8, 2017
@dmose
feat(performance): mozilla#2539 Add perf telemetry + infrastructure
340d6ee
dmose added a commit to dmose/activity-stream that referenced this issue Jun 10, 2017
@dmose
feat(performance): mozilla#2539 Add perf telemetry + infrastructure
73a957a
dmose added a commit to dmose/activity-stream that referenced this issue Jun 13, 2017
@dmose
feat(performance): mozilla#2539 Add perf telemetry + infrastructure
2ffab92
@dmose dmose mentioned this issue Jun 15, 2017
Closed
@dmose
Copy link
Member Author

dmose commented Jun 15, 2017

Spun off #2726 for sending the new_tab_preloaded telemetry

dmose pushed a commit that referenced this issue Jun 16, 2017
feat(performance): #2539 Add perf telemetry + infrastructure (#2681)
ef6f2d2 
* feat(performance): #2539 Add perf telemetry + infrastructure
@dmose dmose closed this as completed Jun 16, 2017
@dmose dmose mentioned this issue Jun 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmose dmose

Labels
Has PR MVP P1 Performance
Projects
None yet
Milestone
Bridge on the River Kwai (June 25)
Development

No branches or pull requests
4 participants
@jaredlockhart @dmose @Mardak @sarracini