This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
fix(mc): Load default sites from a pref that is empty for testing #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mardak
force-pushed
the
gh2710-defaults
branch
2 times, most recently
from
f84f94e
to
ee56a35
Compare
k88hudson
approved these changes
Jun 20, 2017
system-addon/lib/ActivityStream.jsm
Outdated
| @@ -33,6 +33,11 @@ XPCOMUtils.defineLazyModuleGetter(this, "TopSitesFeed", | |||
| "resource://activity-stream/lib/TopSitesFeed.jsm"); | |||
|
|
|||
| const PREFS_CONFIG = [ | |||
| { | |||
| name: "default.sites", | |||
| title: "Default top sites to fill in behind visited sites", | |||
There was a problem hiding this comment.
Maybe as a comma-separated list?
|
Woohoo! We have dots on perfherder again! https://mzl.la/2syxIR3 There's a 6% improvement on tp5o, 4% improvement on tsvg_static, and 11% improvement on tart relative to when it last ran on OS X April 24th… ;) (Looks like plenty of progress with quantum flow.) Also looks like windows10 has replaced windows8 talos runs since May 31st. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2710. r?@k88hudson Use a list of sites stored in the default preferences to initialize the
DEFAULT_TOP_SITESarray, so testing can set the pref to "" to avoid screenshotting.