This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
test(card): Closes #2906 Test system-addon Card UI #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piatra
suggested changes
Aug 4, 2017
| it("should display a title", () => assert.equal(wrapper.find(".card-title").text(), DEFAULT_PROPS.link.title)); | ||
| it("should display a description", () => assert.equal(wrapper.find(".card-description").text(), DEFAULT_PROPS.link.description)); | ||
| it("should display a host name", () => assert.equal(wrapper.find(".card-host-name").text(), "foo")); | ||
| it("should display an image if there is one, with the correct background", () => assert.equal(wrapper.find(".card-preview-image").props().style.backgroundImage, `url(${DEFAULT_PROPS.link.image})`)); |
There was a problem hiding this comment.
Can you break this line up & 32 as well. Too long.
| assert.equal(options, DEFAULT_PROPS.contextMenuOptions); | ||
| assert.equal(index, DEFAULT_PROPS.index); | ||
| }); | ||
| it("should pass through the correct menu options to LinkMenu if overriden by individual card", () => { |
| it("should display a host name", () => assert.equal(wrapper.find(".card-host-name").text(), "foo")); | ||
| it("should display an image if there is one, with the correct background", () => assert.equal(wrapper.find(".card-preview-image").props().style.backgroundImage, `url(${DEFAULT_PROPS.link.image})`)); | ||
| it("should not show an image if there isn't one", () => { | ||
| delete DEFAULT_PROPS.link.image; |
There was a problem hiding this comment.
This test is always green, regardless of this line.
| // first dispatch call is the SendToMain message which will open a link in a window, and send some event data | ||
| assert.calledWith(DEFAULT_PROPS.dispatch.firstCall, ac.SendToMain({ | ||
| type: at.OPEN_LINK, | ||
| data: Object.assign(DEFAULT_PROPS.link, {event: {altKey: "", button: "", ctrlKey: "", metaKey: "", shiftKey: ""}}) |
There was a problem hiding this comment.
Events are not properly tested here. Your click call only provides preventDefault so the values for the events should be undefined not "".
Could you use DEFAULT_PROPS.dispatch.firstCall.args[0].data.event and test the events with some actual values?
piatra
approved these changes
Aug 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.