This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
Revert #3007 use Services.telemetry.canRecordBase for snippets telemetry #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… telemetry This reverts commit aeee212.
|
We're going to need to do an uplift to 56 that includes this patch. What's the right way to go about that? Cut a branch for 56 and export to beta from there? CC @Mardak |
|
We could. Depends on how many things we're expecting to uplift to 56. Just making sure, this really is needed for the shield study? |
|
@Mardak, in the interest of being consistent with our data policy, I think we should. It turns out that canRecord* is just about whether Fx is allowed to record telemetry, and that that's often set to true even when the upload preference is set to false. :-( |
|
Uplifted to firefox-56 branch 5aa2666 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2183. This reverts commit aeee212.
After some discussion with gfritzsche, it looks like we need to use the datareporting.healthreport.uploadEnabled pref (which refers to the uploading of data) not .canRecordBase, which refers to the recording of data.