Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

fix(screenshots): Split bytes into smaller chunks to run through fromCharCode #3101

Merged
merged 1 commit into from
Aug 8, 2017
Merged

fix(screenshots): Split bytes into smaller chunks to run through fromCharCode #3101

merged 1 commit into from
Aug 8, 2017

Conversation

Mardak
Copy link
Member

@Mardak Mardak commented Aug 5, 2017

Fix #3099. r?@sarracini Add a helper function that can consistently process large number of bytes. Adds tests for it too!

@Mardak Mardak requested a review from sarracini August 5, 2017 05:23
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling aa7233b on Mardak:gh3099-args into 54a5392 on mozilla:master.

sarracini
sarracini approved these changes Aug 8, 2017
View reviewed changes
Copy link
Contributor

@sarracini sarracini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sarracini sarracini assigned Mardak and unassigned sarracini Aug 8, 2017
@Mardak Mardak merged commit 14c051f into mozilla:master Aug 8, 2017
@Mardak Mardak deleted the gh3099-args branch August 8, 2017 15:27
@as-pine-proxy
Copy link
Collaborator

Treeherder: 173f357863a5a62870b290ebfaafdf7faf9ea909

@Mardak Mardak mentioned this pull request Aug 8, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarracini sarracini sarracini approved these changes

Assignees

@Mardak Mardak

Labels
PR / R+ pushed-to-pine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mardak @coveralls @as-pine-proxy @sarracini