This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Use startHidden and noShell attribute to hide command prompt window #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this seems reasonable to me! (Sorry for the delay, I only just noticed this while digging through my inbox... Feel free to request a review in the future!) There are a few other places where we use |
jryans
approved these changes
May 22, 2018
|
I have asked Patrick to add you to the DevTools GitHub team so that you can merge things when you're ready to do so. For now, I'll merge this change. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, when using adbhelper on Windows, command prompt is showen at startup. Since Firefox 55 and 58 have additional options, I would like to use it to hide command prompt window on Windows.