Bug 1075490 - Fix devtools docking. #1829
Conversation
| // panel documents in a content process, but for now platform implementation | ||
| // is buggy on linux so this is disabled. | ||
| // We end up using chrome iframe with forced message manager | ||
| // as fixing a swapFrameLoader seemd like a giant task (see |
| @@ -150,6 +169,7 @@ exports["test Panel communication"] = test(function*(assert) { | |||
| yield closeToolbox(); | |||
|
|
|||
| assert.equal(panel.readyState, "destroyed", "panel is destroyed"); | |||
| myTool.destroy(); | |||
There was a problem hiding this comment.
this seems unrelated, if it is then please make a separate bug for this change.
|
We should have a test that it's not possible to have the local content (which passes validation) redirect to non-local content. |
|
This is failing on travis: 7114 of 7118 tests passed. JPM info There were test failures... JPM info ./test/test-dev-panel.test Panel API: timed out JPM info ./test/test-dev-panel.test communication with debuggee: timed out |
@Gozala Which ones? |
| @@ -82,21 +85,21 @@ const observer = { | |||
| observerService.removeObserver(observer, topic); | |||
| } | |||
| else if (document === content.document) { | |||
| if (topic === "content-document-interactive") { | |||
| if (topic.endsWith("-document-interactive")) { | |||
There was a problem hiding this comment.
this is an unrelated change, please separate this change in to another bug.
There was a problem hiding this comment.
this is an unrelated change, please separate this change in to another bug.
It is related because if content is chrome privileged topic will be `chrome-document-interactive"
I've already pointed out that travis will fail .as it depend on platform change |
I'm afraid I can't make such guarantees, since we make this local content chrome privileged it can do whatever it pleased no matter how hard we try. |
|
@erikvold I removed those Also now that related platform changes are in nightly travis is happy and passing tests! |
|
Created separate pull for test cleanups as requested here #1847 |
|
Also here is a link to unload tests that came up in the discussion #1848 |
| observerService.addObserver(observer, "content-page-hidden", false); | ||
| observerService.addObserver(observer, "chrome-document-interactive", false); | ||
| observerService.addObserver(observer, "chrome-document-loaded", false); | ||
| addEventListener("unload", observer, false); |
There was a problem hiding this comment.
Shouldn't you remove this listener at some point? Same question for observerService?
Or is this frame script global and want to dispatch events for all document living in the tab?
Bug 1075490 - Fix devtools docking. r=@ochameau
Depends on platform change attached here (https://bug1075490.bugzilla.mozilla.org/attachment.cgi?id=8546311)