fix: Correctly detect insecure CSP when default-src is missing. #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob--W
force-pushed
the
csp-fix-5
branch
2 times, most recently
from
bab37e0
to
214a7b4
Compare
willdurand
approved these changes
Nov 15, 2022
| @@ -1922,12 +1919,13 @@ describe('ManifestJSONParser', () => { | |||
|
|
|||
| const keys = Object.keys(contentSecurityPolicy); | |||
| for (let i = 0; i < keys.length; i++) { | |||
| expect(warningsV3[i].code).toEqual(messages.MANIFEST_CSP_UNSAFE_EVAL); | |||
| expect(warningsV3[i].message).toContain( | |||
| expect(warningsV3[i * 2].code).toEqual(messages.MANIFEST_CSP_UNSAFE_EVAL); | |||
There was a problem hiding this comment.
maybe mention that we expect two codes for each key, and so first warning is MANIFEST_CSP_UNSAFE_EVAL and second warning is MANIFEST_CSP.
| @@ -1888,6 +1883,8 @@ describe('ManifestJSONParser', () => { | |||
| expect(warnings[0].message).toEqual( | |||
| messages.manifestCspUnsafeEval('content_security_policy').message | |||
| ); | |||
| expect(warnings[1].code).toEqual(messages.MANIFEST_CSP); | |||
| expect(warnings.length).toBe(2); | |||
There was a problem hiding this comment.
Suggested change
| expect(warnings.length).toBe(2); | |
| expect(warnings.length).toEqual(2); |
| } | ||
| expect(warningsV3.length).toBe(3); | ||
| expect(warningsV3.length).toBe(6); |
There was a problem hiding this comment.
Suggested change
| expect(warningsV3.length).toBe(6); | |
| expect(warningsV3.length).toEqual(6); |
Codecov ReportBase: 98.74% // Head: 98.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4594 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 54 54
Lines 2859 2859
Branches 859 859
=======================================
Hits 2823 2823
Misses 36 36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4578.