-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Report a warning on manifest_version 3 extensions targeting Firefox for Android #5105
Conversation
0af0774
to
fd5aad5
Compare
cb82254
to
9ff4aed
Compare
9ff4aed
to
4478b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5105 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 54 54
Lines 2922 2927 +5
Branches 888 891 +3
=======================================
+ Hits 2885 2890 +5
Misses 37 37 ☔ View full report in Codecov by Sentry. |
…r of tracking it as a separate followup.
@willdurand as we agreed earlier today, I've filed a separate followup to add the shorted link in the description of the new warning (tracked by #5110), then updated this PR accordingly. This should be ready for your final review pass. |
Fixes #5104
TODO List
┆Issue is synchronized with this Jira Task