Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report a warning on manifest_version 3 extensions targeting Firefox for Android #5105

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

rpl
Copy link
Member

@rpl rpl commented Nov 13, 2023

Fixes #5104

TODO List

┆Issue is synchronized with this Jira Task

@rpl rpl marked this pull request as draft November 13, 2023 19:41
@rpl rpl force-pushed the fix-warn-on-mv3-fenix-extensions branch from 0af0774 to fd5aad5 Compare November 13, 2023 19:50
@rpl rpl marked this pull request as ready for review November 13, 2023 19:51
src/messages/manifestjson.js Outdated Show resolved Hide resolved
@rpl rpl force-pushed the fix-warn-on-mv3-fenix-extensions branch 2 times, most recently from cb82254 to 9ff4aed Compare November 13, 2023 20:09
@rpl rpl changed the title fix: Report a warning on manifest_version 3 extensions targeting Firefor for Android fix: Report a warning on manifest_version 3 extensions targeting Firefox for Android Nov 13, 2023
@rpl rpl force-pushed the fix-warn-on-mv3-fenix-extensions branch from 9ff4aed to 4478b05 Compare November 13, 2023 20:11
Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.

docs/rules.md Outdated Show resolved Hide resolved
src/messages/manifestjson.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50380ff) 98.73% compared to head (eecd911) 98.73%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5105   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          54       54           
  Lines        2922     2927    +5     
  Branches      888      891    +3     
=======================================
+ Hits         2885     2890    +5     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpl rpl requested a review from willdurand November 20, 2023 19:17
@rpl
Copy link
Member Author

rpl commented Nov 20, 2023

@willdurand as we agreed earlier today, I've filed a separate followup to add the shorted link in the description of the new warning (tracked by #5110), then updated this PR accordingly. This should be ready for your final review pass.

@rpl rpl merged commit 6f7d62e into master Nov 20, 2023
5 checks passed
@rpl rpl deleted the fix-warn-on-mv3-fenix-extensions branch November 20, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report a warning on manifest_version 3 targeting Firefox for Android
2 participants