Link add-ons without names to their review page from the review queue

[abhn]

Describe the problem and steps to reproduce it:

Add-ons without names show an unlinked — in the review queue

While it is possible to get the add-on ID from the review queue's HTML table row element (tr#addon-<id>) and get to its review page, it would be more convenient to just link it like other add-ons with names.

Personally, I don't see why add-ons without names (or whitespaces for names) would be allowed, but that doesn't have to change for this issue to be fixed.

What happened?

Add-on without name (or with whitespace name) doesn't get linked from review queue to its review page

What did you expect to happen?

Add-on without name should be linked from the review queue to its review page

┆Issue is synchronized with this Jira Task

[wagnerand]

Add-ons without names are not allowed, so I think we are missing a check somewhere. My bet would be around localized names.

[wagnerand]

@abhn can you provide the guid/link to that add-on?

[abhn]

@wagnerand here's the guid: {ac87cfd8-47b1-4401-b32e-f033af5ed96c}

[wagnerand]

manifest.json:

  "name": "          ",

I'm not sure where exactly we are doing the name-check, possibly in addons-linter, but we should handle that case.

[eviljeff]

I started investigating this - I can replicate locally by using django admin to clear the add-on name. There's an error being thrown somewhere in the call stack for the rendering of that table cell that is causing it to be just rendering with — i.e. it's not even getting to our render_addon_name method.

(It's a djangotables2 Table that is being rendered in a jinja2 template making the debugging a little trickier than sticking in a ipdb.set_trace)