[fix bug 1121914] Next pager arrow wrong direction on /firefox/desktop/tips #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexgibson
commented
Jan 15, 2015
alexgibson
commented
- Fixes "Next" pager arrow pointing the wrong direction.
- Also fixes some small-screen layout issues in the header on RTL locales.
| float: left; | ||
| &:after { | ||
| content: ' »'; | ||
| } |
There was a problem hiding this comment.
Use the trailing-arrow mixin?
|
I'm guessing you're right about an ad blocker causing the issues in bug 1121733. Let's see if we can confirm that in today's meeting, and, if so, change the class & id on that element. |
Sounds good to me 👍 |
alexgibson
force-pushed
the
bug-1121914-pager-arrow-tips-page
branch
from
7a92cb0
to
3b032f0
Compare
|
@jpetto - updated with a 2nd commit that should hopefully fix bug 1121733 |
|
LGTM. Couldn't reproduce the issue from bug 1121733 (no matter how aggressive I configured ABP), but the (potential, hopeful) fix shouldn't hurt anything. r+! |
jpetto
added a commit
that referenced
this pull request
Jan 15, 2015
…-page [fix bug 1121914] Next pager arrow wrong direction on /firefox/desktop/tips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.