-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug 1135693: Add update scripts to repo. #2767
Fix bug 1135693: Add update scripts to repo. #2767
Conversation
@jgmize r? I also took the liberty of cleaning up some of the code and fixing issues with the dev autoupdate script. |
Specific chief alterations required after this merges:
Also on that last point I believe that calling that |
@superawesome you may have opinions on this one as well. |
I'mma split out the part of this that will fix dev autoupdating. Don't merge this until that one is merged and this is rebased. |
35ddec3
to
0429696
Compare
@jgmize rebased and updated. |
@pmclanahan this lgtm, but I'd feel better if @superawesome would take a look as well before we merge this one. |
@jgmize I went ahead and moved the chief deploy script for product-details in here. We'd just need to symlink to this one from the old one like we've done for all of the rest of the chief commander scripts. |
After this merges we'll only need to symlink the old p-d deployment script to this one, like the rest of the chief scripts are.
a16eb8d
to
908c52c
Compare
Thanks @pmclanahan. @superawesome if this looks good to you I'd like to merge this, and then would you mind making the appropriate puppet changes after we push this to prod? |
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1135693#c4 I think we're good to go :) |
…1135693 Fix bug 1135693: Add update scripts to repo.
Moves the scripts run by cron to this repo. Also included is the script to update product-details, but I believe we have to alter chief to have it be the one that is run, or at least symlink to this one from the original path.