Bug 1239386 - Add donations to Thunderbird start page. #4181
Conversation
|
This page is currently localized, you need to use a |
|
Added l10n_has_tag. Is there anything else to do? And at what point can those be removed? Let's say if localizers don't pick it up within a reasonable time (as an example). |
| <div> | ||
| <section> | ||
| <h2>{{ _('Contribute to Thunderbird') }}</h2> | ||
| <p>{{ _('To ensure that Thunderbird continues to improve, as it has for the last ten years, active contributors <a href="%s">recently organized</a> to focus on the future.')|format('https://blog.mozilla.org/thunderbird/2014/11/thunderbird-reorganizes-at-2014-toronto-summit/') }} | ||
| {{ _('Now is a great time for you to <a href="%s" class="iconic">get involved</a>.')|format('https://wiki.mozilla.org/Thunderbird#Contributing') }} | ||
| {{ _('Now is a great time for you to <a href="%s">get involved</a>.')|format('https://wiki.mozilla.org/Thunderbird#Contributing') }} |
There was a problem hiding this comment.
Sorry, this count as a string change.
…onditionally display the donate link
Fix Bug 1255518 - Firefox download buttons: drop support for OS X 10.6-10.8, take 2
…-css-support [fix bug 1264749] Deprecate CSS support for IE 8.
…ribute-tasks Add functional tests for /contribute tasks
…otype-a-gtm-update [fix bug 1279222] Update GTM on homepage prototpye A.
|
So we're good to go? |
The field name in the clean method was misspelled.
…-send-to-device [fix bug 1281045] Remove 'hu' from send to device locales
Enable product-details cache for tests to improve speed
…ion-hello-ftu [fix bug 1273837] Decommission Hello FTU and redirect to Hello product page
…act-pages [fix bug 1275530] Serve IE8 users the basic version of /contact pages
Fix Bug 1281648 - default ios version should be 4.0 instead of 3.0 in release notes
| @@ -11,6 +11,43 @@ | |||
| <header> | |||
| <h1>{{ self.title() }}</h1> | |||
| </header> | |||
| {% if false and l10n_has_tag('thunderbird_startpage_donate_2016_06') %} | |||
There was a problem hiding this comment.
The content is not visible as you seem to have left a false and in the conditional here.
There was a problem hiding this comment.
Ah, leftover from testing
|
Aside from the two comments this change looks fine to me r+wc. If it's something you are comfortable with, can you please squash your commits? If not, please let me know and I can take care of it when merging. Also sorry this one slipped under the radar, the week prior to an all hands is always pretty hectic 🇬🇧 |
…ge-layout [fix bug 1281951] patent page title formatting
Fix bug 1280217: FSA Major free text should pass to basket
…redesigned-download-page [fix bug 1278184] Implement improved /new redesigned download page
…redesigned-firstrun-page [fix bug 1278190] Implement improved /firstrun redesigned page
Bug 1239386 - update to use if l10n_has_tag('thunderbird_startpage_donate_2016_06')
Bug 1239386 - add back class attr, the css needed for it, and don't conditionally display the donate link
Remove debug (if false) and make donate link go to /thunderbird/ also in the menu.
…bedrock into bug1239386_tb_startpage
…onditionally display the donate link
…bedrock into bug1239386_tb_startpage
|
Please go ahead with the squash. |
|
@mkmelin - it looks like something has gone a little wrong here, you now have 37 commits in this PR many of which should not be included. Is this something you can fix? Please let me know if not and I'll see if I can salvage the PR. |
Description
Add a request to donate to the Thunderbird start page.
Bugzilla link
https://bugzilla.mozilla.org/show_bug.cgi?id=1239386
Testing
Checklist