Revert "Use mozfun.norm.fenix_app_info for nondesktop_clients_last_seen" #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbertsch
approved these changes
Aug 21, 2020
jklukas
added a commit
that referenced
this pull request
Aug 31, 2020
See #1250 for proposed logic of how to parse a date from the 10-digit format, but this change should be reliable for the specific case of determining whether we are before or after the 2020-07-03 epoch where naming of apps and channels changed. This will affect GLAM and GUD. Reverts #1249 I will plan to run a backfill for GUD on the same day I merge this, and then communicate out the change to data users, since channel breakdowns in GUD will change for Fenix and Firefox Preview.
jklukas
added a commit
that referenced
this pull request
Aug 31, 2020
See #1250 for proposed logic of how to parse a date from the 10-digit format, but this change should be reliable for the specific case of determining whether we are before or after the 2020-07-03 epoch where naming of apps and channels changed. This will affect GLAM and GUD. Reverts #1249 I will plan to run a backfill for GUD on the same day I merge this, and then communicate out the change to data users, since channel breakdowns in GUD will change for Fenix and Firefox Preview.
jklukas
added a commit
that referenced
this pull request
Sep 1, 2020
See #1250 for proposed logic of how to parse a date from the 10-digit format, but this change should be reliable for the specific case of determining whether we are before or after the 2020-07-03 epoch where naming of apps and channels changed. This will affect GLAM and GUD. Reverts #1249 I will plan to run a backfill for GUD on the same day I merge this, and then communicate out the change to data users, since channel breakdowns in GUD will change for Fenix and Firefox Preview.
jklukas
added a commit
that referenced
this pull request
Sep 1, 2020
See #1250 for proposed logic of how to parse a date from the 10-digit format, but this change should be reliable for the specific case of determining whether we are before or after the 2020-07-03 epoch where naming of apps and channels changed. This will affect GLAM and GUD. Reverts #1249 I will plan to run a backfill for GUD on the same day I merge this, and then communicate out the change to data users, since channel breakdowns in GUD will change for Fenix and Firefox Preview.
jklukas
added a commit
that referenced
this pull request
Sep 9, 2020
See #1250 for proposed logic of how to parse a date from the 10-digit format, but this change should be reliable for the specific case of determining whether we are before or after the 2020-07-03 epoch where naming of apps and channels changed. This will affect GLAM and GUD. Reverts #1249 I will plan to run a backfill for GUD on the same day I merge this, and then communicate out the change to data users, since channel breakdowns in GUD will change for Fenix and Firefox Preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1245
This approach is currently broken due to a recent change in app_build format being reported by Fenix (see #1248).