-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DENG-3462 create view on top of clients_last_seen_v2 with new boolean… #5406
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
sql/moz-fx-data-shared-prod/telemetry/clients_last_seen_v2/view.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| CREATE OR REPLACE VIEW | ||
| `moz-fx-data-shared-prod.telemetry.clients_last_seen_v2` | ||
| AS | ||
| SELECT | ||
| cls.* EXCEPT (app_name), | ||
| CASE | ||
| WHEN cls.isp_name = 'BrowserStack' | ||
| THEN CONCAT(cls.app_name, ' ', cls.isp_name) | ||
| WHEN distribution_id = 'MozillaOnline' | ||
| THEN CONCAT(cls.app_name, ' ', cls.distribution_id) | ||
| ELSE cls.app_name | ||
| END AS app_name, | ||
| IFNULL(mozfun.bits28.days_since_seen(cls.days_active_bits) = 0, FALSE) AS is_dau, | ||
| IFNULL(mozfun.bits28.days_since_seen(cls.days_active_bits) < 7, FALSE) AS is_wau, | ||
| IFNULL(mozfun.bits28.days_since_seen(cls.days_active_bits) < 28, FALSE) AS is_mau, | ||
| IFNULL(mozfun.bits28.days_since_seen(cls.days_seen_bits) = 0, FALSE) AS is_daily_user, | ||
| IFNULL(mozfun.bits28.days_since_seen(cls.days_active_bits) < 7, FALSE) AS is_weekly_user, | ||
| IFNULL(mozfun.bits28.days_since_seen(cls.days_seen_bits) < 28, FALSE) AS is_monthly_user, | ||
| IF( | ||
| LOWER(IFNULL(cls.isp_name, '')) <> "browserstack" | ||
| AND LOWER(cls.distribution_id) <> "mozillaonline", | ||
| TRUE, | ||
| FALSE | ||
| ) AS is_desktop, | ||
| FALSE AS is_mobile | ||
| FROM | ||
| `moz-fx-data-shared-prod.telemetry_derived.clients_last_seen_v2` cls | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this adds value here. I'd say it can go in the view as it doesn't require a calculation and it's safe to assume that anyone querying this view would be interested in Desktop data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, will take it out - thanks @lucia-vargas-a !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up question: since we've removed this column, how will the
active_usersview union work? We'll define the column in the view?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, in the view logic in active_users, we'll just add this is_mobile column for this portion there