-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate the protection is active even on pages where is nothing to block #199
Comments
It might be also good to be able to report, there is something missed by the traction protection blocklist on a site. |
The add-on should block Google Analytics on GitHub. Are you running another blocking add-on? |
Sorry, on GitHub it was caused by ad blocking add-on already blocking GA there. But that was just wrong example. You can try on http://jasnapakablog.mozilla.cz/, where is nothing to block. |
Thanks for clarification. Labeling as UX enhancement. |
We fine tuned the Shield icon to differentiate 3 situations, please find the link below for more details, thanks. https://mozilla.invisionapp.com/share/GK8ZKDR75#/196906617_Proposal_1 |
Will this work even in Private browsing? Per #12, TP is now disabled there, but I do not see the add-on icon in the address bar in Private browsing, so I assume using Blok results in no TP in Private browsing. |
That was a bug in the Test Pilot add-on that should be fixed as of yesterday's Test Pilot add-on update. So, you should see Tracking Protection enabled in PBM windows again. |
@ChenMorpheus I'm still a bit concerned that a change this radical will affect the experiment a bit since people have already been onboarded with one type of UI. Also, we'll have to materially change the onboarding to accommodate the UI change. Perhaps we could just do a greyed out shield if no tracking exists on a page? |
@johngruen Sorry that I didn't notice the comment. |
As the experiment is closed, closing this issue too. |
When you open a page, like GitHub, where the tracking protection does not block any element, it should be clear it actually works. Currently there is just no shield icon in the address bar and it looks more like the add-on does not work. To indicate it's just not active on the site, let's make it gray or visually different another way, but keep it there.
The text was updated successfully, but these errors were encountered: