Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate the protection is active even on pages where is nothing to block #199

Closed
MikkCZ opened this issue Oct 17, 2016 · 10 comments
Closed

Comments

@MikkCZ
Copy link

MikkCZ commented Oct 17, 2016

When you open a page, like GitHub, where the tracking protection does not block any element, it should be clear it actually works. Currently there is just no shield icon in the address bar and it looks more like the add-on does not work. To indicate it's just not active on the site, let's make it gray or visually different another way, but keep it there.

@MikkCZ
Copy link
Author

MikkCZ commented Oct 17, 2016

It might be also good to be able to report, there is something missed by the traction protection blocklist on a site.

@groovecoder
Copy link
Member

The add-on should block Google Analytics on GitHub. Are you running another blocking add-on?

@MikkCZ
Copy link
Author

MikkCZ commented Oct 17, 2016

Sorry, on GitHub it was caused by ad blocking add-on already blocking GA there. But that was just wrong example. You can try on http://jasnapakablog.mozilla.cz/, where is nothing to block.

@groovecoder
Copy link
Member

Thanks for clarification. Labeling as UX enhancement.

@ChenMorpheus
Copy link

We fine tuned the Shield icon to differentiate 3 situations, please find the link below for more details, thanks.

https://mozilla.invisionapp.com/share/GK8ZKDR75#/196906617_Proposal_1

@MikkCZ
Copy link
Author

MikkCZ commented Oct 26, 2016

Will this work even in Private browsing? Per #12, TP is now disabled there, but I do not see the add-on icon in the address bar in Private browsing, so I assume using Blok results in no TP in Private browsing.

@groovecoder
Copy link
Member

That was a bug in the Test Pilot add-on that should be fixed as of yesterday's Test Pilot add-on update. So, you should see Tracking Protection enabled in PBM windows again.

@johngruen
Copy link
Contributor

@ChenMorpheus I'm still a bit concerned that a change this radical will affect the experiment a bit since people have already been onboarded with one type of UI. Also, we'll have to materially change the onboarding to accommodate the UI change. Perhaps we could just do a greyed out shield if no tracking exists on a page?

@ChenMorpheus
Copy link

@johngruen Sorry that I didn't notice the comment.
If the effort to implement our proposal is big, then we can just grey out the shield icon.

@MikkCZ
Copy link
Author

MikkCZ commented Apr 2, 2017

As the experiment is closed, closing this issue too.

@MikkCZ MikkCZ closed this as completed Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants