Revised handlebars boolean variables to be more succinct.

mozilla · Apr 1, 2020 · b46b979 · b46b979
1 parent d489c0b
commit b46b979
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/controllers/home.js b/controllers/home.js
@@ -16,11 +16,8 @@ async function home(req, res) {
   const coinFlipNumber = Math.random() * 100;
   const experimentBranch = getExperimentBranch(req, coinFlipNumber);
 
-  const isUserInExperiment = isExperiment(experimentBranch);
-  let experimentBranchB = false;
-  if (experimentBranch === "vb" && isUserInExperiment) {
-    experimentBranchB = true;
-  }
+  const isUserInExperiment = (experimentBranch === "vb" || experimentBranch === "vc");
+  const experimentBranchB = (experimentBranch === "vb" && isUserInExperiment);
 
   let featuredBreach = null;
   let scanFeaturedBreach = false;
@@ -67,11 +64,6 @@ async function home(req, res) {
   });
 }
 
-function isExperiment(experimentBranch) {
-  if (experimentBranch === "vb" || experimentBranch === "vc") { return true; }
-  return false;
-}
-
 function getExperimentBranch(req, sorterNum) {
 
   if (!req.headers["accept-language"].includes("en") ){