Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Clicking “Sign In/Sign Up for Alerts” buttons from the main page with a random string entered in the email field, wrongly transfers the string to “Sign in” page #1618

Closed
heres-maria-sv-inactive opened this issue Mar 26, 2020 · 1 comment
Assignees
Labels
growth-team Growth team

Comments

@heres-maria-sv-inactive
Copy link

heres-maria-sv-inactive commented Mar 26, 2020

[Notes]:

  • If the email field from the main page remains empty and the “Sign in” button is pressed, the “Sign in” page wrongly displays the invalid email error as if you tried to submit the empty field
  • After the steps below are executed, navigating to a breach from the “Breaches” page and clicking the “Sign in” or “Sign Up for Alerts” page buttons also transfers the string initially entered in the main page.

[Affected Versions]:

  • Firefox Beta Build ID 20200309155231
  • Chrome 80.0.3987.149
  • Firefox (Fennec) 68.6.0

[Affected Platforms]:

  • Windows 10 (x64)
  • Android 9 - Samsung Galaxy S8

[Prerequisites]:

  • You are on the Monitor mainpage, on any branch.
  • You have not performed a breach search, nor have you signed into an account until now.

[Steps to reproduce]:

  1. Enter a random string, not a valid email, in the email text field.
  2. Click the "Sign In" button from the header.
  3. After being redirected to the “Sign in” page, observe the email field.

[Expected results]:

  • The email field is empty, the entered string is not transferred.

[Actual results]:

  • The email field is wrongly populated with the string entered in the main page email field.

[Additional Notes]:

  • Attached is a recording of the issue.
    new sa
@heres-maria-sv-inactive heres-maria-sv-inactive changed the title [Experiment] The "Enter your Email" page is pre-filled with the contents of the "Enter Email Address" field, even if a brach search has not been performed [Experiment] The "Enter your email" page is pre-filled with the contents of the "Enter email Address" field, even if a breach search has not been performed Mar 26, 2020
@heres-maria-sv-inactive heres-maria-sv-inactive changed the title [Experiment] The "Enter your email" page is pre-filled with the contents of the "Enter email Address" field, even if a breach search has not been performed [Experiment] Clicking “Sign In/Sign Up for Alerts” buttons from the main page with a random string entered in the email field, wrongly transfers the string to “Sign in” page Mar 26, 2020
@maxxcrawford maxxcrawford added the growth-team Growth team label Mar 26, 2020
maxxcrawford added a commit that referenced this issue Mar 26, 2020
…unction Logic and gated all experiment code to happen after initial function (via options truthy check). This means FxA sign ups (via the experiment checkbox) only run logic from that ONE BUTTON. All other OAuth fires happen as expected, using previous tested logic.
@maxxcrawford maxxcrawford self-assigned this Mar 26, 2020
@heres-maria-sv-inactive
Copy link
Author

I have verified that this issue is no longer reproducible using Firefox Beta 75.0b1 Build ID 20200309155231 on Windows 10 (x64), Firefox 23 on iOS 13.3.1 (iPhone 7+), as well as Firefox 68.6.0 on Android 10 (Motorola One Vision).
The content of the email text field is no longer remembered for any of the sign-ins.
As a result, I am closing this issue.

maxxcrawford added a commit that referenced this issue Mar 30, 2020
…unction Logic and gated all experiment code to happen after initial function (via options truthy check). This means FxA sign ups (via the experiment checkbox) only run logic from that ONE BUTTON. All other OAuth fires happen as expected, using previous tested logic.
maxxcrawford added a commit that referenced this issue Apr 1, 2020
…unction Logic and gated all experiment code to happen after initial function (via options truthy check). This means FxA sign ups (via the experiment checkbox) only run logic from that ONE BUTTON. All other OAuth fires happen as expected, using previous tested logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
growth-team Growth team
Projects
None yet
Development

No branches or pull requests

2 participants