Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a deterministic component in email verification token #33

Closed
nhnt11 opened this issue Feb 7, 2018 · 2 comments
Closed

Include a deterministic component in email verification token #33

nhnt11 opened this issue Feb 7, 2018 · 2 comments

Comments

@nhnt11
Copy link
Contributor

nhnt11 commented Feb 7, 2018

To prevent the extremely unlikely scenario of a clash. Simply requiring the email address as a request parameter should suffice.
@nhnt11
Copy link
Contributor Author

nhnt11 commented Feb 7, 2018 •
edited
Loading

We could also use a salted hash as the token instead of random bytes, but I still think we should require the email address as a parameter.

@nhnt11 nhnt11 mentioned this issue Feb 7, 2018
Merged
@groovecoder
Copy link
Member

We're using uuidv4 for verification tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@groovecoder @nhnt11