MNTOR-2929 - avoid server error and add logging, with followup #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansaj
reviewed
Feb 9, 2024
| @@ -96,7 +97,12 @@ export async function getUserBreaches({ | |||
| export async function getSubscriberBreaches( | |||
| user: Session["user"], | |||
| ): Promise<SubscriberBreach[]> { | |||
| // FIXME this does not always return a subscriber https://mozilla-hub.atlassian.net/browse/MNTOR-2936 | |||
| const subscriber = await getSubscriberByEmail(user.email); | |||
There was a problem hiding this comment.
Do we know if user.email is always present and not the problem?
Might as well log that if not
There was a problem hiding this comment.
@mansaj we're logging the whole user object below, that's exactly the sort of thing I want to check. I think we need to be more consistent in what we use for looking up users - fxa ID would be better than email I think. I have a hunch what's causing this but I want to see the data first
There was a problem hiding this comment.
oh sorry, i misread.. that makes sense
mansaj
approved these changes
Feb 9, 2024
| @@ -96,7 +97,12 @@ export async function getUserBreaches({ | |||
| export async function getSubscriberBreaches( | |||
| user: Session["user"], | |||
| ): Promise<SubscriberBreach[]> { | |||
| // FIXME this does not always return a subscriber https://mozilla-hub.atlassian.net/browse/MNTOR-2936 | |||
| const subscriber = await getSubscriberByEmail(user.email); | |||
There was a problem hiding this comment.
oh sorry, i misread.. that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-2929
Description
We can see from Sentry that
getSubscriberByEmailsometimes returnsundefined, which is causing server-side errors for some customers. Add temporary logging to diagnose, with a followup ticket filed to actually fix the problem (linked in FIXME comment).How to test
We're not sure how to reproduce this yet, this will temporarily add extra logging in production (server only).
Checklist (Definition of Done)