Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation screen behind a flag in the cancellation flow #4445

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Add confirmation screen behind a flag in the cancellation flow #4445

merged 8 commits into from
Apr 25, 2024

Conversation

codemist
Copy link
Collaborator

References:

#4409

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist requested a review from Vinnl April 25, 2024 15:10
Vinnl
Vinnl approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks straightforward enough, but with the recent CD changes this might get send to prod unexpectedly, so keeping the whole thing behind a flag as well would be safer.

src/app/(proper_react)/(redesign)/(public)/LandingView.tsx Outdated Show resolved Hide resolved
src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/settings/View.tsx Outdated Show resolved Hide resolved
@codemist codemist merged commit ef39dd1 into main Apr 25, 2024
13 checks passed
@codemist codemist deleted the cancellation-flow-follow branch April 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinnl Vinnl Vinnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codemist @Vinnl