Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send new users the monthly activity email #4494

Merged
merged 2 commits into from
May 8, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented May 7, 2024

References:

Jira: MNTOR-3186
Figma: N/A

Description

The first email should only get sent after the user actually has activity, i.e. after the first month.

How to test

Create a new account, subscribe them to Plus (ensure they have the susbcription in the DB via /admin/dev). Make sure the MonthlyActivityEmail feature flag is enabled for them. Run the npm run dev:cronjobs script. It should not send the email to them - but when you switch to main, it does.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - N/A, DB query
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

The first email should only get sent after the user actually has
activity, i.e. after the first month.
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label May 7, 2024
@Vinnl Vinnl requested review from rhelmer and mansaj May 7, 2024 09:51
@Vinnl Vinnl self-assigned this May 7, 2024
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I wish we had an easy way to unit test SQL changes.

@Vinnl Vinnl merged commit 08477f8 into main May 8, 2024
14 checks passed
@Vinnl Vinnl deleted the MNTOR-3186-new-users-activity-email branch May 8, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants