MNTOR-3155 - Add dev-admin-only server action to look up fxa uid by email address #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-4574-mgjlpikfea-uk.a.run.app |
Vinnl
approved these changes
May 22, 2024
src/app/(proper_react)/(redesign)/(authenticated)/admin/dev/UserAdmin.tsx
Outdated
Show resolved
Hide resolved
…erAdmin.tsx Co-authored-by: Vincent <Vinnl@users.noreply.github.com>
|
Cleanup completed - database 'blurts-server-pr-4574' destroyed, cloud run service 'blurts-server-pr-4574' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3155
Description
PR #4573 changed the
admin/userAPI to look up by FxA UID instead of email address, but I didn't make the equivalent change to the local-dev-onlyadmin/devUI. This adds a local-dev-only, admin-only server action to look up the fxa UID for the sha1 hash of an email address.This isn't the most efficient way to do things since it's introducing another round-trip to the server. We might consider as a follow-up just moving all the server-side work into a server action and not using the API, but on the other hand it's nice to have the client exercise the API.
How to test
Use the local-dev-only
admin/devUI to look up a user and perform actions on the account.Checklist (Definition of Done)