Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E w Mocks: Mntor-3140, Mntor-3141, Mntor-3422 #4613

Merged
merged 8 commits into from
Aug 1, 2024
Merged

E2E w Mocks: Mntor-3140, Mntor-3141, Mntor-3422 #4613

merged 8 commits into from
Aug 1, 2024

Conversation

mozilloid
Copy link
Contributor

@mozilloid mozilloid commented May 30, 2024

References:

Jira: MNTOR-3140, MNTOR-3141, MNTOR-3422
Figma:

Description

Marked more tests as smoke (e2e PR job). Unblocked mntor-3140, and mntor-3141 using mocks.

Screenshot (if applicable)

Not applicable.

How to test

  • Set app_env to local
  • Set onerep and hibp endpoints to corresponding mocks
  • run normal 'npx playwright' commands

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@mozilloid mozilloid marked this pull request as ready for review May 30, 2024 16:40
@mozilloid mozilloid requested a review from pdehaan May 30, 2024 16:40
Copy link

@mozilloid mozilloid self-assigned this May 31, 2024
@mozilloid mozilloid requested review from mansaj and removed request for pdehaan and mansaj May 31, 2024 07:41
@mozilloid mozilloid marked this pull request as draft June 3, 2024 18:49
@mozilloid mozilloid marked this pull request as ready for review July 27, 2024 00:35
@mozilloid mozilloid requested a review from mansaj July 27, 2024 00:35
@mozilloid mozilloid changed the title Mntor-3140 - Verify that the dashboard is displayed correctly for users with no scan results and no breaches E2E w Mocks: Mntor-3140, Mntor-3141, Mntor-3422 Jul 27, 2024
Copy link
Collaborator

@mansaj mansaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work!

@mozilloid mozilloid merged commit 62ec4eb into main Aug 1, 2024
15 checks passed
@mozilloid mozilloid deleted the mntor-3140 branch August 1, 2024 00:47
Copy link

github-actions bot commented Aug 1, 2024

Cleanup completed - database 'blurts-server-pr-4613' destroyed, cloud run service 'blurts-server-pr-4613' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants