-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNTOR-3465: HIBP responses with 429 #4966
Conversation
Preview URL 🚀 : https://blurts-server-pr-4966-mgjlpikfea-uk.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably do want to be notified if the topic is not found, should that one report to Sentry or do you think logger.error
is sufficient? That one is unlikely to fix itself
added sentry, it is much easier than combing through the logs at this point. |
Cleanup completed - database 'blurts-server-pr-4966' destroyed, cloud run service 'blurts-server-pr-4966' destroyed |
References:
Jira: MNTOR-3465
Description
Respond with 429 instead of 500 for HIBP webhook
Checklist (Definition of Done)