Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3465: HIBP responses with 429 #4966

Merged
merged 5 commits into from
Aug 24, 2024
Merged

MNTOR-3465: HIBP responses with 429 #4966

merged 5 commits into from
Aug 24, 2024

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Aug 21, 2024

References:

Jira: MNTOR-3465

Description

Respond with 429 instead of 500 for HIBP webhook

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@mansaj mansaj requested a review from rhelmer August 21, 2024 01:37
@mansaj mansaj marked this pull request as ready for review August 21, 2024 01:37
Copy link

Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably do want to be notified if the topic is not found, should that one report to Sentry or do you think logger.error is sufficient? That one is unlikely to fix itself

@mansaj
Copy link
Collaborator Author

mansaj commented Aug 21, 2024

We probably do want to be notified if the topic is not found, should that one report to Sentry or do you think logger.error is sufficient? That one is unlikely to fix itself

added sentry, it is much easier than combing through the logs at this point.
Do you think 429 or 500 make more sense here

@mansaj mansaj requested a review from rhelmer August 21, 2024 22:57
@mansaj mansaj merged commit 1439d90 into main Aug 24, 2024
15 checks passed
@mansaj mansaj deleted the MNTOR-3465 branch August 24, 2024 00:47
Copy link

Cleanup completed - database 'blurts-server-pr-4966' destroyed, cloud run service 'blurts-server-pr-4966' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants